fix(k8s): fix paths in requests to kubernetes api #5476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimBeyer
previously approved these changes
Nov 23, 2023
TimBeyer
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using absolute paths in URLs e.g.
/versionfor initializing the kubernetes provider, we need to remove the leading slash due to the way URL constructs the full URL. If we don't remove it, it is seen as an absolute path which leads to all other parts of the path to be stripped. For example if this URL is specified in the kubeconfig for a Kubernetes api serverhttps://rancher.18.194.162.172.sslip.io/k8s/clusters/c-m-qkrwsnsgwhen adding the
/versionendpoint we get:https://rancher.18.194.162.172.sslip.io/versionThis causes the request to fail. Instead we need:
https://rancher.18.194.162.172.sslip.io/k8s/clusters/c-m-qkrwsnsg/versionThis PR fixes this behavior.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: