Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13: [Bug]: Logic for parsing Dockerfiles and computing inclusions is missing for action configs #5523

Open
vvagaytsev opened this issue Dec 6, 2023 · 3 comments

Comments

@vvagaytsev
Copy link
Collaborator

The logic for parsing Dockerfiles and computing the file inclusions from them is only being used for module configs, not action configs. That needs to be fixed.

Current Behavior

Dockerfiles are parsed and processed only when using module configs.

Expected behavior

Dockerfiles should be parsed and processed when using both action and module configs.

Reproducible example

Workaround

None.

Suggested solution(s)

Additional context

See containerHelpers.autoResolveIncludes helper.

Your environment

  • OS:
  • How I'm running Kubernetes:

garden version 0.13.21

@vvagaytsev
Copy link
Collaborator Author

This was discovered while debugging #5317. Thanks, @thsig!

@vvagaytsev vvagaytsev self-assigned this Dec 6, 2023
@thsig
Copy link
Collaborator

thsig commented Feb 14, 2024

I seem to recall this being fixed the other day—do you remember, @vvagaytsev?

@vvagaytsev vvagaytsev removed their assignment Feb 14, 2024
@vvagaytsev
Copy link
Collaborator Author

@thsig yes, we still need to fix it. I haven't had a chance to do it so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants