fix(examples): ensure Vue web servers start correctly #5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some examples, the Vue web server wouldn't start correctly due to how eslint was set up and the version of some of its dependencies. This commit fixes that.
eysi09
force-pushed
the
fix-vote-examples
branch
from
a5205b2
to
da860b8
Compare
stefreak
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In some example projects, the Vue web server wouldn't start correctly due to how
eslintwas set up and the version of some of its dependencies.This commit fixes that.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This does not fix the issue with the page not being found when run on local Kubernetes. We'll need to address that specifically but I suspect it has to do with hostfile issue we've had in the past.
I tested all examples by just creating a port forward and they worked as expected.