-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): don't execute disabled dependencies #5697
Conversation
When executing an action that depends on a disabled dependency, the disabled dependency should be skipped (unless it's a build). This is fixed here (in accordance with the docstring for the `disabled` field on action configs).
2eecdbe
to
cad0477
Compare
Before this change, we did execute disabled actions if they were dependencies Now the behaviour changes to silently skip executing disabled actions if other actions directly depend on them. Is that right? I would have expected an error message or at least a warning here; Another question that comes to my mind is if we need to treat this as a breaking change? How did 0.12 behave? |
We did execute disabled actions if they were dependencies of a non-disabled action being processed. Now, we only execute disabled Builds in this way, but not disabled Deploys/Tests/Runs. This is what the docs say, and that's why this user was confused about the changed behaviour from 0.12 (where we did indeed ignore disabled dependencies). I'm not sure whether to treat this as a breaking change, since this change means we're bringing the behaviour in line with the docs for the ... that said, I'm also cool with holding off on merging this until the next minor/non-patch release. |
Here's the relevant docstring that populates the reference docs for the garden/core/src/actions/base.ts Lines 169 to 173 in 15b0e8d
|
I think if this was what the documentation said and how 0.12 behaved like, then we should move forward with this and merge 👍 Thanks for the clarification @thsig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, LGTM 👍
What this PR does / why we need it:
When executing an action that depends on a disabled dependency, the disabled dependency should be skipped (unless it's a build).
This is fixed here (in accordance with the docstring for the
disabled
field on action configs).