improvement(ext-tools): always print versions in garden tools output
#5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do it for all tools, not only for Terraform, Pulumi and Helm.
Added tests to verify binary hashes.
thsig
approved these changes
Feb 12, 2024
vvagaytsev
changed the title
garden tools outputgarden tools output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To improve UX, let's always print the concrete versions of the tools in the
garden toolsoutput.This PR also does refactoring in the tool definitions. It extracts tools versions as named constants to make the version update process easier. The PR also adds some missing tests to verify the binary hashes for the tools.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: