fix(module-conversion): skip omitted build deps #5727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a module has a build dependency on another module that doesn't have a corresponding Build after being converted into actions (e.g. a build dependency on a `terraform` module), we now log a warning and remove the dependency from the generated actions instead of erroring out. In 0.12, some users had build dependencies on modules with no-op build steps (e.g. `terraform`, `kubernetes` and `helm` modules) While this was harmless in 0.12, this resulted in noisy errors before this fix.
thsig
force-pushed
the
warn-on-removed-module-build-deps
branch
from
3c5f691
to
226aed8
Compare
vvagaytsev
reviewed
Feb 13, 2024
|
LGTM, thank you! I've left a comment, that's not critical. I'll approve the PR. |
vvagaytsev
approved these changes
Feb 13, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
) **What this PR does / why we need it**: Use `partition` to separate existing and missing deps, and then process each collection separately, just for better readability and ensuring SRP. A leftover from the core review for #5727 :) **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When a module has a build dependency on another module that doesn't have a corresponding Build after being converted into actions (e.g. a build dependency on a
terraformmodule), we now log a warning and remove the dependency from the generated actions instead of erroring out.In 0.12, some users had build dependencies on modules with no-op build steps (e.g.
terraform,kubernetesandhelmmodules)While this was harmless in 0.12, this resulted in noisy errors before this fix.