improvement(core): less noisy missing dep errors #5732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, we would include a stack trace in the error logged when a requested action has a missing dependency.
thsig
added a commit
that referenced
this pull request
Feb 26, 2024
This reverts commit 91d25bc. When dependencies failed, the `null` input version caused problems with the Cloud API. I'll follow this up with a proper fix that improves the error messages in Core without causing Cloud API issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this fix, we would include a stack trace in the error logged when a requested action has a missing dependency. This was very noisy and indicated a problem with Garden (when it's a totally normal user error).