fix(k8s): retry websocket errors #5755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5729 We failed retrying WebsocketError during Pod exec operations, because the regex "WebsocketError: Unexpected server response" did not match anymore after we refactored toKubernetesError, because the formatting cahnged. Let's retry if just the name WebsocketError appears in the message.
stefreak
force-pushed
the
retry-kubernetes-exec
branch
from
c4966ae
to
bab4bcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We failed retrying
WebsocketErrorduring Pod exec operations, because the regex "WebsocketError: Unexpected server response" did not matchanymore after we refactored
toKubernetesError, because the formattingchanged.
Let's retry if just the name
WebsocketErrorappears in the message.Which issue(s) this PR fixes:
Fixes #5729
Special notes for your reviewer: