Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): attempt execing on running pod #5782

Merged
merged 1 commit into from Feb 26, 2024
Merged

fix(k8s): attempt execing on running pod #5782

merged 1 commit into from Feb 26, 2024

Conversation

stefreak
Copy link
Member

@stefreak stefreak commented Feb 26, 2024

What this PR does / why we need it:
Try to choose a running Pod for execing into. Without this, users might get the following error persistently if the first pod happened to be crashlooping:

run.test✖ Failed processing Run type=kubernetes-exec name=test (took 12.35 sec). This is what happened:

────────────────────────────────────────────────────────────────────────────────────────────────────
Error while performing Kubernetes API operation Pod exec: WebsocketError

Unexpected server response: 500
────────────────────────────────────────────────────────────────────────────────────────────────────

Which issue(s) this PR fixes:

Fixes #5729

Special notes for your reviewer:

@stefreak stefreak requested a review from 10ko February 26, 2024 16:59
@stefreak stefreak changed the title fix exec running pod fix(k8s): attempt execing on running pod Feb 26, 2024
@10ko 10ko enabled auto-merge February 26, 2024 17:07
@10ko 10ko added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit 8b94e49 Feb 26, 2024
40 checks passed
@10ko 10ko deleted the fix-exec-running-pod branch February 26, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash Report: Error while performing Kubernetes API operation Pod exec: WebsocketError
2 participants