improvement: improvements to validate command #5809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the `garden validate` command would fully resolve the config graph. This caused problems for users that had references to runtime outputs of actions in their action configs, since fully resolving the graph in such cases means executing the action (e.g. actually building/deploying). Here, we change the default behavior of the validate command to only partially resolve the config graph, but also introduce a `--resolve` CLI option for resolving some or all actions fully. This allows users to fully resolve action configs for debugging purposes, but also to sidestep action configs with runtime output references.
vvagaytsev
reviewed
Mar 5, 2024
vvagaytsev
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this commit, the
garden validatecommand would fully resolve the config graph. This caused problems for users that had references to runtime outputs of actions in their action configs, since fully resolving the graph in such cases means executing the action (e.g. actually building/deploying).Here, we change the default behavior of the validate command to only partially resolve the config graph, but also introduce a
--resolveCLI option for resolving some or all actions fully. This allows users to fully resolve action configs for debugging purposes, but also to sidestep action configs with runtime output references.Which issue(s) this PR fixes:
Fixes #5695.