feat(modules): allow opting out of build staging #5890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
reviewed
Mar 28, 2024
edvald
reviewed
Mar 28, 2024
thsig
force-pushed
the
modules-make-local-option-global
branch
from
32f7f71
to
305bd76
Compare
edvald
previously approved these changes
Mar 28, 2024
thsig
force-pushed
the
modules-make-local-option-global
branch
from
305bd76
to
5104b54
Compare
|
There were a few test failures, should be good to go now @edvald. |
edvald
previously approved these changes
Mar 28, 2024
Here, we make the `local` config field (previously only available to `exec` modules) available for all module types. When used, it maps to the `buildAtSource` field of any generated Build actions in the module conversion process. This is done because some users/projects need to reference symlinked directories in their builds, where the simplest solution appears to be to simply opt out of build staging for those modules.
thsig
force-pushed
the
modules-make-local-option-global
branch
from
5104b54
to
a26004c
Compare
edvald
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Here, we make the
localconfig field (previously only available toexecmodules) available for all module types.When used, it maps to the
buildAtSourcefield of any generated Build actions in the module conversion process.This is done because some users/projects that haven't migrated from modules to actions yet need to reference symlinked directories in their builds, where the simplest solution appears to be to simply opt out of build staging for those modules.
Which issue(s) this PR fixes:
Workaround for #2382.
Notes for reviewer:
Will this cause problems with build copying? Does allowing this violate any subtle invariants?