Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseModule() should not return a Module instance #90

Closed
edvald opened this issue May 11, 2018 · 0 comments
Closed

parseModule() should not return a Module instance #90

edvald opened this issue May 11, 2018 · 0 comments
Assignees

Comments

@edvald
Copy link
Collaborator

edvald commented May 11, 2018

It's a bit of a stability/security concern to let plugins return potentially non-compliant objects that are used in the framework. The parseModule() handler should instead return a module config that can be validated, potentially with a free-form key that can be passed back to plugin action handlers.

Plugins would then be responsible for upgrading basic Module objects to more specific subclasses, or we could perhaps add some convenience feature for doing that automatically before passing to action handlers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant