Garden page #57
Closed
Garden page #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capndave
reviewed
Oct 26, 2020
|
Went ahead and cleared out the MockComponent and corresponding server mocks, as there are plenty of real-use examples now. |
|
@paytonagreen sorry I didn't merge this back when. At this point the project has changed quite a bit, does it make more sense to scrap this or try to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Resolves: #31
Description:
Implemented all of the basic functionality of the Gardens component to the Garden component, identifying the Garden by URL query string, rendering a form to add a Bed to this Garden and a BedList of its already-existing Bed children. When a new bed is added, the list is immediately updated with the new data. I see potential for a reusability refactor down the road, but wanted to get this functionality up and running.
Added SINGLE_GARDEN_QUERY to 'queries' and CREATE_BED_MUTATION to 'mutations', along with their respective mocks to 'mocks/handlers'.
Tests:
New components are tested for proper rendering and static functionality, as well as proper handling of the new query and mutation. Integration testing in the Garden component is not possible due to not using live data, definite possible use case for doing some e2e testing eventually - at the moment I can assert that it works as expected.
Checklist:
Please put an x in each box that you have completed