Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Protect referenced secrets with finalizer #41

Merged
merged 1 commit into from Mar 31, 2020
Merged

Conversation

timebertt
Copy link
Contributor

What this PR does / why we need it:
With this PR, grm adds its finalizer to every Secret referenced in a ManagedResource.
It deletes the finalizers again, after the deletion has succeeded.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`gardener-resource-manager` now adds finalizers to Secrets referenced in `ManagedResource`s to prevent Secrets from being deleted accidentally.

@timebertt timebertt requested a review from a team as a code owner March 27, 2020 13:42
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 27, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 27, 2020
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 50e86bb into master Mar 31, 2020
@rfranzke rfranzke deleted the enh/secret-finalizer branch March 31, 2020 04:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants