This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
Offer auto-delete on invalid update operation for managed resources #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/usability
gardener-robot-ci-2
added
reviewed/ok-to-test
rfranzke
force-pushed
the
feature/delete-on-forbidden-changes
branch
from
5379456
to
5496754
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
|
/needs/rebase |
gardener-robot
added
needs/rebase
|
@rfranzke The pull request was assigned to you under |
rfranzke
force-pushed
the
feature/delete-on-forbidden-changes
branch
from
5496754
to
47c49a8
Compare
|
/unassign |
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
needs/review
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot
removed
the
status/author-action
|
/assign |
timuthy
approved these changes
Jul 15, 2020
gardener-robot
added
reviewed/lgtm
This was referenced Aug 13, 2020
Merged
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability
/kind enhancement
/priority normal
What this PR does / why we need it:
The
ManagedResourcecontroller is now capable of auto-deleting a resource in case an update fails with the "invalid" error and the resource is properly annotated to allow this behaviour.This is useful if a managed resource, e.g. a
StorageClassorPod, shall be updated and those updates are not allowed by the API server.Special notes for your reviewer:
The Kubernetes API server sends a
422 Unprocessable Entityerror in case it static validation fails. Unfortunately, its status codes returned on errors of admission plugins as well as the status codes returned by (validating) admission webhooks are not necessarily streamlined. Consequently, I decided to exclude those cases for now and limit the solution on errors happening during static validation. Probably, this is fine for the vast majority of our use-cases within the Gardener project.Release note: