This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
Conditions lastUpdateTime is no longer updated continuously
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot
added
priority/3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area scalability robustness
/kind enhancement
/priority normal
What this PR does / why we need it:
Similar to gardener/gardener#2888, the
ManagedResource's.status.conditions[].lastUpdateTimeis no longer continuously updated to prevent spamming etcd with too many unnecessary updates.Special notes for your reviewer:
As of today, there is no controller that would check if the GRM is down and set the conditions statuses to
Unknown(contrary to what we do forShoots, for example). We could introduce it in the future, but it's not clear yet if we want that and how that would look like.Release note: