-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@mfranczy Command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Please see the comments on the specific lines of code, some of them apply to multiple files, please fix them everywhere. Also, please:
- Squash all commits into one (Gardener policy)
- Add a VERSION file
- Add
.ci
scripts from https://github.com/gardener/machine-controller-manager-provider-vsphere and make sure all Makefile targest work - Do
make revendor
, currently some files are not properly vendored
@moadqassem Could you also please add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moadqassem Thanks for addressing all remaining comments! Please see a new comment that I think is probably a bug.
Reg. my comments about adding additional targets to the Makefile using Gardener hack
scripts, that could also be addressed in a future PR.
Yeah I will take care of that :-). I also still need to squash my comments and wait for another PR to be merged on the original repo(it is a PR that @mfranczy has opened regarding Dockerfile) |
@moadqassem the docker file PR has been rebased moadqassem#1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the constructor issue! Some more requests:
- Please add +x flag on
.ci/build
and.ci/check
. - Please fix all linter issues:
$ make check
Running go vet...
# github.com/gardener/machine-controller-manager-provider-kubevirt/cmd/machine-controller
cmd/machine-controller/main.go:45:3: Fprint call has possible formatting directive %v
make: *** [check] Error 2
- Please add a
verify
target that callstest
andcheck
. We should use it for averify
check (until we addverify-extended
as suggested previously).
8462228
to
719d82f
Compare
mvladev is in vacation and his comments have been already addressed
* adding tests for kubevirt cloud provider core module * adding .ci dir * injecting the kubevirt client in the cloud provider plugin * add Dockerfile and build script * fixing linter and vet issues Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
What this PR does / why we need it:
Adding Kubevirt cloud provider
Release note: