Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

Add hugepages support #20

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

mfranczy
Copy link
Contributor

@mfranczy mfranczy commented Sep 30, 2020

Signed-off-by: Marcin Franczyk marcin0franczyk@gmail.com

What this PR does / why we need it:
Supports hugepages
Which issue(s) this PR fixes:
Fixes # gardener-attic/gardener-extension-provider-kubevirt#36

Special notes for your reviewer:

Release note:

improvement_user

Signed-off-by: Marcin Franczyk <marcin0franczyk@gmail.com>
@mfranczy mfranczy requested a review from a team as a code owner September 30, 2020 14:29
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 30, 2020
@mfranczy
Copy link
Contributor Author

Please don't merge, I am testing this now.

@mfranczy mfranczy added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Sep 30, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 30, 2020
@mfranczy mfranczy changed the title add hugepages support Add hugepages support Sep 30, 2020
@mfranczy mfranczy removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Oct 1, 2020
@mfranczy
Copy link
Contributor Author

mfranczy commented Oct 1, 2020

I tested and it looks good, I see hugepages attached to vm spec.

pkg/kubevirt/core/core.go Show resolved Hide resolved
@stoyanr stoyanr self-requested a review October 1, 2020 13:02
@stoyanr stoyanr merged commit 628efd4 into gardener-attic:master Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants