Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] No_proxy as an Array #121

Closed
commial opened this issue Oct 7, 2014 · 2 comments
Closed

[Feature Request] No_proxy as an Array #121

commial opened this issue Oct 7, 2014 · 2 comments

Comments

@commial
Copy link
Contributor

commial commented Oct 7, 2014

In template /etc/default/docker.erb, no_proxy can be written with:

<% if @no_proxy -%>
export no_proxy='<%= Array(@no_proxy).join(',') %>'
<% end -%>

This should keep compatibility with current version (in 1.2.2, no_proxy is a String instance).

This patch allows one to use a list for configuration which permits the use of YAML references.

@garethr
Copy link
Owner

garethr commented Oct 7, 2014

Hi @commial, thanks. Do you want to submit a pull request for this feature, looks about right?

@commial
Copy link
Contributor Author

commial commented Oct 7, 2014

Hi @garethr, thanks for the feedback. It should be OK now.

@commial commial closed this as completed Oct 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants