Scope files by version and group #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Append the version of a kind instead of overriding the same file multiple times.
johanneswuerbach
force-pushed
the
add-version
branch
from
1750efd
to
a139361
Compare
johanneswuerbach
changed the title
This was referenced Mar 19, 2018
ghost
mentioned this pull request
willthames
reviewed
Aug 23, 2018
| @@ -151,6 +151,8 @@ def default(output, schema, prefix, stand_alone, kubernetes, strict): | |||
|
|
|||
| info("Generating individual schemas") | |||
| for title in data['definitions']: | |||
| group = title.split('.')[-3].lower() | |||
| version = title.split('.')[-2].lower() | |||
There was a problem hiding this comment.
This will need to be called something else as version now reflects swagger/openapi version.
I just changed my fork of this to use api_version and it works well
|
Finally getting some time to come back to maintaining these tools. I've just applied this patch with a few changes, in particular putting it behind a flag and restricting to the Kubernetes code path. Once I've generated the relevant schemas for all the versions, and reworked some of the publishing, I'll be updating |
lirik90
pushed a commit
to lirik90/swagger2jsonschema
that referenced
this pull request
Mar 30, 2024
Bump mypy from 1.8.0 to 1.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append the version of a kind instead of overriding the same file multiple times.
Required for instrumenta/kubeval#57