Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails on npm run build #44

Closed
jjstrat3 opened this issue Dec 16, 2016 · 7 comments
Closed

Fails on npm run build #44

jjstrat3 opened this issue Dec 16, 2016 · 7 comments

Comments

@jjstrat3
Copy link

jjstrat3 commented Dec 16, 2016 •
edited

First off, great library @garetmckinley !

I just pulled down your library locally to do some hacking on it for the purpose of possibly contributing on some of the outstanding open issues. It failed on executing npm run build on my machine.

Here's my steps after cloning your repo:

  1. yarn install
  2. npm run build

I get this output in my terminal:

> hedron@0.4.0 build /Users/jstratton/Documents/workspace/hedron
> npm run build:lib && npm run build:dist


> hedron@0.4.0 build:lib /Users/jstratton/Documents/workspace/hedron
> babel src --out-dir lib

node_modules/nan
resolve failed:  { Error: Cannot find module 'eslint-module-utils'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.requireRelative.resolve (/Users/jstratton/Documents/workspace/hedron/node_modules/require-relative/index.js:30:17)
    at resolve (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:25:26)
    at findAndRemove (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:67:11)
    at /Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:111:13
    at Array.map (native)
    at loadPreset (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:103:29)
    at module.exports (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/index.js:97:19)
    at Object.<anonymous> (/Users/jstratton/Documents/workspace/hedron/node_modules/babel-preset-es2015-rollup/index.js:3:18)
    at Module._compile (module.js:570:32) code: 'MODULE_NOT_FOUND' } eslint-module-utils
resolve failed:  { Error: Cannot find module 'babel-runtime'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.requireRelative.resolve (/Users/jstratton/Documents/workspace/hedron/node_modules/require-relative/index.js:30:17)
    at resolve (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:25:26)
    at findAndRemove (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:67:11)
    at /Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:111:13
    at Array.map (native)
    at loadPreset (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:103:29)
    at module.exports (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/index.js:97:19)
    at Object.<anonymous> (/Users/jstratton/Documents/workspace/hedron/node_modules/babel-preset-es2015-rollup/index.js:3:18)
    at Module._compile (module.js:570:32) code: 'MODULE_NOT_FOUND' } babel-runtime
src/components/Column.js -> lib/components/Column.js
src/components/Page.js -> lib/components/Page.js
src/components/Row.js -> lib/components/Row.js
src/index.js -> lib/index.js
src/utils/divvy.js -> lib/utils/divvy.js
src/utils/index.js -> lib/utils/index.js
src/utils/media.js -> lib/utils/media.js
src/utils/passOn.js -> lib/utils/passOn.js

> hedron@0.4.0 build:dist /Users/jstratton/Documents/workspace/hedron
> rollup -c && rollup -c --environment PRODUCTION

Creating development bundle...
node_modules/nan
resolve failed:  { Error: Cannot find module 'eslint-module-utils'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.requireRelative.resolve (/Users/jstratton/Documents/workspace/hedron/node_modules/require-relative/index.js:30:17)
    at resolve (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:25:26)
    at findAndRemove (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:67:11)
    at /Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:111:13
    at Array.map (native)
    at loadPreset (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:103:29)
    at module.exports (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/index.js:97:19)
    at Object.<anonymous> (/Users/jstratton/Documents/workspace/hedron/node_modules/babel-preset-es2015-rollup/index.js:3:18)
    at Module._compile (module.js:570:32) code: 'MODULE_NOT_FOUND' } eslint-module-utils
resolve failed:  { Error: Cannot find module 'babel-runtime'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.requireRelative.resolve (/Users/jstratton/Documents/workspace/hedron/node_modules/require-relative/index.js:30:17)
    at resolve (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:25:26)
    at findAndRemove (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:67:11)
    at /Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:111:13
    at Array.map (native)
    at loadPreset (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:103:29)
    at module.exports (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/index.js:97:19)
    at Object.<anonymous> (/Users/jstratton/Documents/workspace/hedron/node_modules/babel-preset-es2015-rollup/index.js:3:18)
    at Module._compile (module.js:570:32) code: 'MODULE_NOT_FOUND' } babel-runtime
Creating production bundle...
node_modules/nan
resolve failed:  { Error: Cannot find module 'eslint-module-utils'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.requireRelative.resolve (/Users/jstratton/Documents/workspace/hedron/node_modules/require-relative/index.js:30:17)
    at resolve (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:25:26)
    at findAndRemove (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:67:11)
    at /Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:111:13
    at Array.map (native)
    at loadPreset (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:103:29)
    at module.exports (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/index.js:97:19)
    at Object.<anonymous> (/Users/jstratton/Documents/workspace/hedron/node_modules/babel-preset-es2015-rollup/index.js:3:18)
    at Module._compile (module.js:570:32) code: 'MODULE_NOT_FOUND' } eslint-module-utils
resolve failed:  { Error: Cannot find module 'babel-runtime'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.requireRelative.resolve (/Users/jstratton/Documents/workspace/hedron/node_modules/require-relative/index.js:30:17)
    at resolve (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:25:26)
    at findAndRemove (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:67:11)
    at /Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:111:13
    at Array.map (native)
    at loadPreset (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/lib/serialize.js:103:29)
    at module.exports (/Users/jstratton/Documents/workspace/hedron/node_modules/modify-babel-preset/index.js:97:19)
    at Object.<anonymous> (/Users/jstratton/Documents/workspace/hedron/node_modules/babel-preset-es2015-rollup/index.js:3:18)
    at Module._compile (module.js:570:32) code: 'MODULE_NOT_FOUND' } babel-runtime

Possibly an upstream dependency of babel rollup preset??
@AriTheElk
Copy link
Owner

Hello, thanks for the kind words! Sorry you're having those issues though, do you have either eslint or babel installed at a global scope? I'm going to test out a fresh clone of this repo on my other computer in the hopes I can duplicate the issue.

@jjstrat3
Copy link
Author

@garetmckinley Np. Don't have eslint or babel installed globally, just the eslint-cli npm module...which hasn't caused issues for me before with my own projects, but who knows. ;)
If it's relevant, I'm using 6.9.1 of node via nvm.

@AriTheElk
Copy link
Owner

OK, so I found a few interesting things!

On a fresh clone of the repo, I get identical output to you. However, my package is still compiled in the dist/ subdir. Can you check and see if the same is true for you?

I can't seep to supress the eslint-module-utils error though, even after I run npm install --save-dev eslint-module-utils. I'm running node v7.0.0.

@mikkom mikkom mentioned this issue Dec 17, 2016
Merged
@mikkom
Copy link
Contributor

mikkom commented Dec 20, 2016

@garetmckinley I guess this can be closed now as well since #45 has been merged?

@jjstrat3
Copy link
Author

@mikkom @garetmckinley haven't had a chance to test it yet again, but I'll pull latest as soon as I get to the office in the next hour

@jjstrat3
Copy link
Author

@mikkom @garetmckinley pulled latest from master, and everything seems to build fine. I'll go ahead and close this. Thanks!

@AriTheElk
Copy link
Owner

Awesome, glad to hear @jjstrat3 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikkom @AriTheElk @jjstrat3