Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

ThemeEditor public apply method needs null check #45

Closed
ross-holloway94 opened this issue May 6, 2019 · 0 comments
Closed

ThemeEditor public apply method needs null check #45

ross-holloway94 opened this issue May 6, 2019 · 0 comments

Comments

@ross-holloway94
Copy link

ross-holloway94 commented May 6, 2019

The Readme states:

The apply method optionally takes a high-order function as a argument. This serves as a callback that will be triggered once Colorful has finished it's theme changes

However, ThemeEditor#apply() infers a @nonnull annotation on both of its arguments.
If this is to match the readme, the callback should be optional, and therefore must have a null check before being called.

I believe this will also make things easier for non-Kotlin users to make use of.

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant