Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Log Level and noisy puppeteer logs #1063

Open
aw-davidson opened this issue Jul 1, 2019 · 1 comment
Open

[Feature] Log Level and noisy puppeteer logs #1063

aw-davidson opened this issue Jul 1, 2019 · 1 comment

Comments

@aw-davidson
Copy link
Contributor

I'm looking to implement improved logging for backstop Backstop. My main issue with backstop logging is the logs coming from "Browser Console Log". Maybe there should just be a config option to turn these off or on, like a verbose flag.

There other option is to implement logging levels which may be too heavy of a solution. I've read up on the discussion over #822 and have some questions. 1. When a level is set, should logging only occur at that level or should logging occur at that level and also at other levels "below" it 2. Should all logs use the special logger in logger.js? 3. what would logLevel: 'OFF' do - would it turn logging output off or would it log outputs at all levels?

How should we deal with the main issue of noisy browser console logs

@pixelastic
Copy link

FWIW, I disabled browser console logs by setting console.log = () => {}; in the onBefore script. This simply override the default console.log with a noop function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants