Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay doesn't fix screenshot #1088

Open
An-dy1 opened this issue Aug 27, 2019 · 1 comment
Open

Delay doesn't fix screenshot #1088

An-dy1 opened this issue Aug 27, 2019 · 1 comment

Comments

@An-dy1
Copy link

An-dy1 commented Aug 27, 2019

Why, when I try to take screenshots of certain sites, do they end up looking like this:
desktop
Here's my config (in which I set the delay to 5 freaking seconds and tried to make it wait until the footer had loaded before I took the screenshot):
{ "id": "backstop_default", "viewports": [ { "label": "phone", "width": 320, "height": 480 }, { "label": "tablet", "width": 1024, "height": 768 }, { "label": "desktop", "width": 1280, "height": 1024 } ], "onBeforeScript": "puppet/onBefore.js", "onReadyScript": "puppet/onReady.js", "scenarios": [ { "label": "VMLYR Home", "cookiePath": "backstop_data/engine_scripts/cookies.json", "url": "https://www.vmlyr.com", "referenceUrl": "", "readyEvent": "", "readySelector": ".region-footer", "delay": 5000, "hideSelectors": [], "removeSelectors": [], "hoverSelector": "", "clickSelector": "", "postInteractionWait": 0, "selectors": [], "selectorExpansion": true, "expect": 0, "misMatchThreshold" : 0.1, "requireSameDimensions": true } ], "paths": { "bitmaps_reference": "backstop_data/bitmaps_reference", "bitmaps_test": "backstop_data/bitmaps_test", "engine_scripts": "backstop_data/engine_scripts", "html_report": "backstop_data/html_report", "ci_report": "backstop_data/ci_report" }, "report": ["browser"], "engine": "puppeteer", "engineOptions": { "args": ["--no-sandbox"] }, "asyncCaptureLimit": 5, "asyncCompareLimit": 50, "debug": false, "debugWindow": false }

@OliaVk
Copy link

OliaVk commented Aug 29, 2019

Hey @An-dy1 . Looks like the #1029 merge is going to fix the issue with resizing the screen before taking screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants