Some usability improvements + tests/docs #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing default manually avoids the hidden requirement that P: Default,
which is not implemented for some std types.
The use case is to allow the priority queue to be easily added to
already-default structures that derive default themselves as:
#[derive(Default)]
struct MyState {
...
pub pq: PriorityQueue<i32, Instant>,
}
Without needing to `impl Default` for the entire struct.
In my specific case, I use the priority queue as a callback mechanism
using time instants from std::time::Instant. If the top elements are
behind the `now()` time, we run these instants and put them back onto
the queue with an added interval (for repeating timers).
When we change a priority, I do not want to change the contents of the element (do not basically want to pop and then push the new thing), because sometimes we have elements (like callbacks in this test) that we want to keep. This patch implements a test that confirms this.
The documentation contains a reference to reversing priority but that's not very useful when you don't know how to use it. This test allows users to see how you use `Reverse`, and confirms that it works.
|
The benchmarks seem to only work on nightly due to the unstable |
|
I don't like it does not work in stable any more |
|
@garro95 if you remove that one it should work. Otherwise we can use a |
|
The latter is what I did |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this crate to implement a timer-based reactor for callbacks, unfortunately
std::time::Instantdoes notimpl Defaultso I can't create a default object ofPriorityQueue.There is no good reason for
Pto beDefault, so this patch series implementsDefaultmanually by relegating tonew, which works for allP: Ord. Deriving default appears to add a hidden requirement forP: Default.