Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hate GitHub.
I cannot reopen my old pull request.
So finally I'll never touch this hook (TTTDelayRoundStartForVote) again.
@Bo98 found some (in my opinion) very crazy coded mapvotes.
They use this hook. So indeed it seems like that there are people who use this hook.
About mapcycle:
I was a bit iritated because in the ttt home page it says:
And in mapcycle.txt it says:
So I thought in isn't really used and I didn't thought about this.
But game.GetMapNext() checks mapcycle.txt
So mapcycle is used in TTT.
Anyway these changes can be made:
These things are really not used.
(My old PRs: #1225 and #1223 )
Next time I will take more time for chaning something. So I can test it and search the internet about it.
I apologize if I confused someone. :(