Fixed GWEN TextureBorder mistake #772

Merged
merged 1 commit into from Jul 31, 2014

Projects

None yet

2 participants

@Metamist
Contributor

The previous code was wrong because _x+_w-_l-_r will return uv x value plus
the width between the left and the right border, while it should be
_x+_w-_r to return the position where the right border starts. This is not
noticeable on the current derma panels, but if you want to make your own
with more features on it, it will be clear that something is wrong.

Examples:
How it looks right now (Top border slightly expanded so you can see the problem easier ):
https://i.imgur.com/7Ornta3.png
How it should look (Ignore red pixels):
https://i.imgur.com/ztzaKND.png

How the png looks like:
http://i.imgur.com/lCfi2aI.png

The left border is the entire grey part on the left, the top border is the top grey part, and the bottom and right border is set to 2

@Metamist Metamist Fixed GWEN TextureBorder typo
The previous code was wrong because _w-_l-_r will return uv x value plus
the width between the left and the right border, while it should be
_w-_r to return the position where the right border starts. This is not
noticeable on the current derma panels, but if you want to make your own
with more features on it, it will be clear that something is wrong.
07d223c
@Metamist Metamist changed the title from Fixed GWEN TextureBorder typo to Fixed GWEN TextureBorder mistake Jul 26, 2014
@robotboy655
Collaborator

👍

@robotboy655 robotboy655 merged commit 73fd56e into garrynewman:master Jul 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment