Fixed GWEN TextureBorder mistake #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code was wrong because _w-_l-_r will return uv x value plus the width between the left and the right border, while it should be _w-_r to return the position where the right border starts. This is not noticeable on the current derma panels, but if you want to make your own with more features on it, it will be clear that something is wrong.
AlexanderArvidsson
changed the title
|
👍 |
robotboy655
added a commit
that referenced
this pull request
Jul 31, 2014
Fixed GWEN TextureBorder mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was wrong because _x+_w-_l-_r will return uv x value plus
the width between the left and the right border, while it should be
_x+_w-_r to return the position where the right border starts. This is not
noticeable on the current derma panels, but if you want to make your own
with more features on it, it will be clear that something is wrong.
Examples:
How it looks right now (Top border slightly expanded so you can see the problem easier ):
https://i.imgur.com/7Ornta3.png
How it should look (Ignore red pixels):
https://i.imgur.com/ztzaKND.png
How the png looks like:
http://i.imgur.com/lCfi2aI.png
The left border is the entire grey part on the left, the top border is the top grey part, and the bottom and right border is set to 2