Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DPropertySheet padding on bottom edge. #859

Closed
wants to merge 0 commits into from
Closed

Fix DPropertySheet padding on bottom edge. #859

wants to merge 0 commits into from

Conversation

AbigailBuccaneer
Copy link
Contributor

Previously the bottom padding on the panel in a DPropertySheet was exactly 8px, because the active tab is 8px taller than the other tabs¹. However, the default padding is 8px, so this is only revealed when changing the padding on a property sheet.

@AshleighAdams
Copy link
Contributor

It'd be better if you didn't use magic numbers.

@AbigailBuccaneer
Copy link
Contributor Author

@Kateadams the 8px that's added by the active tab is a magic number. I went for the most minimal fix instead of also modifying the tab class to not use a magic number. I'll change it. (In fact, given the y-position is hardcoded to 20 + self:GetPadding() regardless of the height of the tabs, it probably makes more sense to use that as the top offset.)

@AbigailBuccaneer
Copy link
Contributor Author

Whoops - I managed to automatically close this and make it unopenable again by updating my AbigailBuccaneer:patch-1 branch in line with garrynewman:master. Apologies, I'll open a new pull request now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants