Elastic Search shutdown

[tormodu]

I have been trying to debug this part of the code trying to shutdown Elastic Search:

public virtual void Stop()
{
   if (_process != null)
        {
            return;
        }

        if (_process.HasExited)
        {
            return;
        }

        _process.CloseMainWindow();
}       

Too me it seems like _process is never null which means that _process.CloseMainWindow(); is never called.

Should the correct implementation be this?

    public virtual void Stop()
    {
        if (_process == null)
        {
            return;
        }

        if (_process.HasExited)
        {
            return;
        }

        _process.CloseMainWindow();

    }

[garvincasimir]

You are right! If you send me a pull I will merge. If not I can make the change later today.

Thanks for contributing. I am thinking of versioning this project and making it one or multiple nuget packages. Want to join up?

[tormodu]

Excellent. nuget packaging sounds like a good idea. I'm in.