Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we make Range a subclass of StaticRange? #1

Closed
chong-z opened this issue May 5, 2016 · 5 comments
Closed

Should we make Range a subclass of StaticRange? #1

chong-z opened this issue May 5, 2016 · 5 comments

Comments

@chong-z
Copy link

chong-z commented May 5, 2016

According to the StaticRange.idl I found (not sure if that's the latest one) there are some duplicate methods with Range.

See @dtapuska comments below, do we still want to make it interface Range : StaticRange?

BTW would it be better to have the an idl inside this explainer?
Here is the idl #2 (comment)

@chong-z chong-z changed the title Should we make Range a subclass of StaticRange? Should we make StaticRange a subclass of Range? Jun 2, 2016
@chong-z
Copy link
Author

chong-z commented Jun 2, 2016

@dtapuska mentioned that StaticRange should be a subclass of Range, but the idl seems disagree.
@garykac @ojanvafai can we have a confirmation on this question? Thanks!

@dtapuska
Copy link

dtapuska commented Jun 2, 2016

I recall that we were talking about changing Range to be a subclass of StaticRange...

ie: interface StaticRange
and
interface Range : StaticRange

I don't recall what the resolution was in January.

@chong-z chong-z changed the title Should we make StaticRange a subclass of Range? Should we make Range a subclass of StaticRange? Jun 3, 2016
@garykac
Copy link
Owner

garykac commented Jun 3, 2016

I recall it being mentioned, but there were concerns about changing the definition of Range. I don't recall details or specific concerns, however.

@chong-z
Copy link
Author

chong-z commented Jun 3, 2016

@garykac thanks for the comments!

I'm currently working on StaticRange and is blocked on this issue (https://crrev.com/2022863002).
Can we keep these two separate for now, and maybe changing Range later if we decided to do so?

@garykac
Copy link
Owner

garykac commented Apr 25, 2017

This issue was moved to w3c/staticrange#1

@garykac garykac closed this as completed Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants