Add more parameters to the launcher script

[wysow]

Hello,

First thanks for this useful image!

It could be great to add some more parameters to the launcher script, especially a -p to allow use of a custom port like docker does, but maybe also some others I don't think of at this time...

What do you think?

[garywiz]

I debated about this. I figured people would take the launcher script, then modify it to suit their purposes. For example, at the top of the launcher script, you can change the EXT_HTTP_PORT line to look something like this:

EXT_HTTP_PORT=80

Then, the launched image will use port 80 instead of 8080.

I could certainly add switches and options too, I just didn't want to over-complicate the launcher script and make it harder to read for people who aren't used to shell scripting so much.

Curious about your thoughts!

[wysow]

Yes both solutions sounds right, just for me as a developer I think that more options is more customization ;). And by the way for people not used to shell scripting if they have to open it to customize, not sure that sounds great for them... ;)

[garywiz]

In this latest release, I've enhanced the launcher script, and included details on the main documentation page. There are probably many more customizations, but is this a good start?

$ ./run-docker-grav.sh -h
Usage: run-docker-grav.sh [-d] [-p port#] [-h]
       Run Grav from garywiz/docker-grav as a daemon (with -d) or 
       interactively (the default).

  -d            Run as daemon (otherwise interactive)
  -p port#      Specify port number to expose Grav server (default 8080)
  -s dirpath    Specifies the path to an optional storage directory where 
                ALL persistent Grav files and settings will be stored.  This allows
                you to keep your site separate from the container so you can easily
                upgrade the container software. By default, this script looks to see 
                if ../docker-grav-storage exists, and if it does, it will be used.  
                You can override that default with this switch.
  -n name       Name the container 'name' instead of the default name invented by Docker.

HTTPS options (SSL):
  -H sslhost    Specify the SSL host name and enable the SSL server.  If specified, Grav
            will also be available using https on the port specified by -P
  -P sslport#   Specify SSL port number (default 8443)

[wysow]

@garywiz sounds like a great start, wiil try it and come back to you if I have some feedback or ideas.