Major speedup to merging of files #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 6db59f3 added a call to update_statistics() to add_testcase(). When merging files, add_testcase() is called many times and every call to update_statistics will walk the entire XML tree again. There is no need to do this on every add_testcase(). Instead update the statistics once after the file has been merged. When merging large JUnit XML files, this reduces the merge time from many minutes to less than one second.
|
These CI failures seem like problems with the CI setup rather than being caused by my pull request. |
weiwei
approved these changes
Sep 15, 2019
|
@arichardson Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6db59f3 added a call to
update_statistics() to add_testcase(). When merging files, add_testcase()
is called many times and every call to update_statistics will walk the
entire XML tree again. There is no need to do this on every add_testcase().
Instead update the statistics once after the file has been merged.
When merging large JUnit XML files, this reduces the merge time from
many minutes to less than one second.