Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support components #4

Merged
merged 5 commits into from Nov 3, 2022
Merged

support components #4

merged 5 commits into from Nov 3, 2022

Conversation

mathildedd
Copy link
Contributor

I am quite unhappy about having to redeclare the subfields as class elements, I think that they should already be class elements, but currently they are arrays.

@Berdir
Copy link
Contributor

Berdir commented Oct 31, 2022

As discussed.

make the component list on group public, reference it from there, fix the property definitions method too and then maybe we can work with that.

also in the new and existing code, check if that field type is defined:

(if !isset()) {
throw new \Exception('Unknown field type $foo');
}

@Berdir Berdir merged commit c54e60a into main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants