Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Set minimum version to illuminate/support": "^8 #26

Open
jwambugu opened this issue Dec 9, 2021 · 2 comments
Open

[enhancement] Set minimum version to illuminate/support": "^8 #26

jwambugu opened this issue Dec 9, 2021 · 2 comments

Comments

@jwambugu
Copy link
Contributor

jwambugu commented Dec 9, 2021

The package currently requires "illuminate/support": "^5.0|^6.0|^7.0|^8.0" which pulls in versions ^5.0|^6.0|^7.0 which might not be getting any security fixes.

Can we have another version which will require the minimum version of illuminate/support to be ^8. This will ensure new projects or updates which satisfy this requirement will also get the security fixes.

@gathuku
Copy link
Owner

gathuku commented Dec 9, 2021

@jwambugu The only support component am using is File::get
Maybe rewriting this to get rid of the File support component can be the best. How do you think?
https://github.com/gathuku/laravel_mpesa/blob/master/src/Mpesa.php#L137-L146

@jwambugu
Copy link
Contributor Author

The whole support package provided a lot of functionality which we can extend to use and refactor this package. And since it's a laravel package, I feel it should remain. That's my opinion 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants