Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: strict vs not strict inequalities in Assertions #2993

Closed
annappropriate opened this issue Apr 27, 2016 · 3 comments
Closed

Core: strict vs not strict inequalities in Assertions #2993

annappropriate opened this issue Apr 27, 2016 · 3 comments

Comments

@annappropriate
Copy link

Part of my simulation definition is assertions(global.failedRequests.percent.lessThan(100))
Gatling output:

---- Response Time Distribution ------------------------------------------------
> t < 800 ms                                            0 (  0%)
> 800 ms < t < 1200 ms                                  0 (  0%)
> t > 1200 ms                                           0 (  0%)
> failed                                               60 (100%)
    <some output skipped>
Global: percentage of failed requests is less than 100 : true

This seems a bit misleading (especially the last line), I wonder if lessThan and greaterThan should be strict inequalities and API should also provide lessThanOrEqual and greaterThanOrEqual or something like that?
Documentation does not say anything about strictness either.

@slandelle
Copy link
Member

I agree.

This can only go in 2.3, as it would be an API breakage (even if it's for the better).
Would you be interested in contributing?

@slandelle slandelle changed the title Assertions: strict vs not strict inequalities Core: strict vs not strict inequalities in Assertions May 9, 2016
@slandelle slandelle added this to the 2.3.0 milestone May 9, 2016
@annappropriate
Copy link
Author

annappropriate commented May 23, 2016

Yes, I'd absolutely love to contribute.

@slandelle
Copy link
Member

  • Let's drop greaterThan and lowerThan
  • Introduce gt, gte, lt, lte
  • Add optional parameters on between with default value to exclude bounds

@slandelle slandelle self-assigned this Aug 3, 2016
@slandelle slandelle modified the milestones: 2.2.3, 3.0.0 Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants