Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP: Wrong Connection header value in WebSocket upgrade request #3606

Closed
slandelle opened this issue Nov 15, 2018 · 1 comment
Closed

HTTP: Wrong Connection header value in WebSocket upgrade request #3606

slandelle opened this issue Nov 15, 2018 · 1 comment
Assignees
@slandelle
Labels
Type - Declined
Milestone
3.0.1

Comments

@slandelle
Copy link
Member

According to RFC6455:

  1. The request MUST contain a |Connection| header field whose value MUST include the "Upgrade" token.

So the correct case is Upgrade. Netty's WebSocketClientHandshaker currently sends upgrade instead. See netty/netty#8558.

Some WebSocket server implementations expect the proper case and crash.
@slandelle slandelle added this to the 3.0.1 milestone Nov 15, 2018
@slandelle slandelle self-assigned this Nov 15, 2018
@slandelle
Copy link
Member Author

Actually, the spec says those are case insensitive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slandelle slandelle

Labels
Type - Declined
Milestone
3.0.1
Development

No branches or pull requests
1 participant
@slandelle