Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referer automatic computation #432

Closed
slandelle opened this issue Mar 8, 2012 · 3 comments
Closed

Referer automatic computation #432

slandelle opened this issue Mar 8, 2012 · 3 comments

Comments

@slandelle
Copy link
Member

Solution proposal:

  • add an automaticReferer on HttpProtocolConfiguration
  • consider that "real" pages are the ones with Accept header containing text/html or application/xhtml+xml and X-Requested-With is absent
  • store the URL of these pages in the Session
  • when automaticReferer is set, automatically add a Referer header with the value stored in the Session

The recorder will be impacted too.

@slandelle
Copy link
Member Author

@BluePyth WDYT?

@ghost ghost assigned slandelle May 22, 2012
@rsertelon
Copy link
Contributor

Maybe an AJAX request can't be considered as a referer also, can they?

I'm wondering whether followRedirect & automaticReferer could be considered true by default. I mean, everybody want to use these features, except in specific cases.

This would allow anyone to benefit from these useful features, with an option to deactivate them. I see this like that:

protocolConfig.noFollowRedirect.noReferer

@slandelle
Copy link
Member Author

Regarding AJAX requests, you're right, so a "real" page should also don't have a X-Requested-With header.

Regarding change the default behavior, I'd rather be cautious. Let's ask people's opinion on the mailing list. But we can have the checkboxes checked by default on the Recorder configuration panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants