Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excerpts link to WP instead of Gatsby #17

Closed
chmac opened this issue Oct 4, 2018 · 2 comments
Closed

Excerpts link to WP instead of Gatsby #17

chmac opened this issue Oct 4, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@chmac
Copy link
Collaborator

chmac commented Oct 4, 2018

The excerpt finishes with a "continue reading..." link which links to the WordPress URL and not the Gatsby URL.
@chmac chmac added the bug Something isn't working label Oct 4, 2018
chmac added a commit that referenced this issue Oct 4, 2018
@chmac
Hide the "Continue reading" links. #17
4538edf 
This is a workaround / hack. It's just a CSS `display: none;`. We should probably do something better.
@chmac
Copy link
Collaborator Author

chmac commented Oct 4, 2018

Suggested adding this to the WordPress source plugin here: gatsbyjs/gatsby#8782

@chmac
Copy link
Collaborator Author

chmac commented Nov 5, 2018

We're filtering this out here:

gatsby-starter-wordpress/src/components/PostList.js

Lines 34 to 38 in 9c7ed16

<div
dangerouslySetInnerHTML={{
__html: post.excerpt.replace(/<p class="link-more.*/, ''),
}}
/>

Not sure how reliable this approach is. But I guess we can close this issue for now.

@chmac chmac closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chmac