Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Real-life usage samples #106

Closed
94rain opened this issue May 8, 2021 · 1 comment
Closed

Updates to Real-life usage samples #106

94rain opened this issue May 8, 2021 · 1 comment

Comments

@94rain
Copy link

94rain commented May 8, 2021

I ran a check on this repo itself and found the following dead links :P

ERROR: 2 dead links found!
[✖] https://github.com/GoogleChrome/lighthouse/blob/master/.github/workflows/check-md-links.yml → Status: 404
[✖] https://github.com/apache/apisix/blob/master/.github/workflows/markdown-link-checker.yml → Status: 404

It seems that lighthouse has moved the workflow configurations to https://github.com/GoogleChrome/lighthouse/blob/master/.github/workflows/cron-weekly.yml

And apisix removed it in apache/apisix#3992 :(.
How about persuading them to re-add it and run it weekly/monthly?

@gaurav-nelson
Copy link
Owner

Thanks @94rain for the updates, I'll fix those links.

Lately, I've seen issues with the underlying library and depending on the use case this might not be the perfect solution in every scenario. So I don't think I can persuade them to add it back unless I know if it works perfectly for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants