Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails for quoted links in markdown #110

Closed
jessesquires opened this issue Jul 6, 2021 · 2 comments
Closed

Fails for quoted links in markdown #110

jessesquires opened this issue Jul 6, 2021 · 2 comments
Labels
bug Something isn't working markdown-link-check Related to the underlying markdown-link-check library

Comments

@jessesquires
Copy link

I have a scenario where link checking fails because links are quoted, and the final " is parsed as part of the link.

This happens when using a Jekyll include.

Example input:

---
layout: post
title: "My title"
---

My blog post.

{% include image.html
   file="image.jpg"
   caption="My caption."
   source_link="https://example.com"
 %}

Example output:

ERROR: 3 dead links found!
129
[✖] https://archive.fortune.com/galleries/2008/fortune/0809/gallery.ibm_then_now.fortune/4.html' → Status: 404
130
[✖] https://www.pressconnects.com/story/news/local/2019/06/20/developers-wanted-ibm-country-club/1509049001/' → Status: 404
131
[✖] https://freepress.org/fleming/flemng44.html' → Status: 404
132

PR: techworkersco/techworkersco.github.io#237

Logs: https://github.com/techworkersco/techworkersco.github.io/runs/3001155166

@gaurav-nelson
Copy link
Owner

Thank you @jessesquires for creating this issue.

This issue comes from the underlying library this action uses markdown-link-extractor. Which in turn uses marked.

PS:

Its a known issue, and I suggest that you follow up on the original issues. Feel free to close this one.

@jessesquires
Copy link
Author

Ah, thanks @gaurav-nelson ! 💯

@gaurav-nelson gaurav-nelson added bug Something isn't working markdown-link-check Related to the underlying markdown-link-check library labels Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working markdown-link-check Related to the underlying markdown-link-check library
Projects
None yet
Development

No branches or pull requests

2 participants