Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status 0 from java.com site #122

Closed
srknzl opened this issue Nov 26, 2021 · 1 comment
Closed

Status 0 from java.com site #122

srknzl opened this issue Nov 26, 2021 · 1 comment
Labels
markdown-link-check Related to the underlying markdown-link-check library

Comments

@srknzl
Copy link

srknzl commented Nov 26, 2021

See https://github.com/hazelcast/hazelcast-nodejs-client/runs/4333651919?check_suite_focus=true for failing CI.

Important part of the output:

FILE: ./code_samples/jaas_sample/hazelcast-member/README.md
[✖] https://www.java.com/en/download/

3 links checked.

ERROR: 1 dead links found!
[✖] https://www.java.com/en/download/ → Status: 0

Note: There is just one link to java.com in our markdown files.

Why do they block us? What to do? Thanks

@gaurav-nelson
Copy link
Owner

@srknzl Thank you for creating the issue.

Some sites block requests from CI processes to prevent DoS attacks and seems like the case for this one. Unfortunately the underlying markdown-link-check tool has no mechanism to avoid such failures.

The only thing you can do to pass the test is to disable check for the failing link.

@gaurav-nelson gaurav-nelson added the markdown-link-check Related to the underlying markdown-link-check library label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markdown-link-check Related to the underlying markdown-link-check library
Projects
None yet
Development

No branches or pull requests

2 participants