Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEIC support is indeed broken in thumbsupgallery/thumbsup? #37

Closed
lhprojects opened this issue May 4, 2023 · 1 comment
Closed

HEIC support is indeed broken in thumbsupgallery/thumbsup? #37

lhprojects opened this issue May 4, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@lhprojects
Copy link

I generated my project based on this one, and it isn't working for .heic files (which is default format on e.g. iOS). I found some error messages in the Actions panel:

2023-05-03T07:14:34.275Z thumbsup:error Error processing 20211106_225752813_iOS.heic -> media/small/20211106_225752813_iOS.jpg
2023-05-03T07:14:34.275Z thumbsup:error Error: Command failed: gm identify: Insufficient image data in file (/tmp/tmp-7-M0CMOZ9sF1A1-.jpg).
2023-05-03T07:14:34.275Z thumbsup:error gm identify: Request did not return an image.

No image was displayed in the gallery for .heic files, although the thumbnail image was displayed correctly.

The thumbsupgallery/thumbsup image was released two years ago. I switched to using ghcr.io/thumbsup/thumbsup:2.17.1 instead of thumbsupgallery/thumbsup. Now, it works for .heic files.

I suggest updating the Docker image used in the project to ghcr.io/thumbsup/thumbsup:2.17.1 or something similar to ensure proper support for .heic files by default.

I'm new to GitHub Actions and Docker, and not able to edit the .yml file proficiently yet. Therefore, I'm opening an issue here.

@gautamkrishnar
Copy link
Owner

Great catch @lhprojects will use the ghcr one

@gautamkrishnar gautamkrishnar self-assigned this May 4, 2023
@gautamkrishnar gautamkrishnar added the enhancement New feature or request label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants