Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous parameters reported in v2 #40

Closed
rfay opened this issue May 20, 2024 · 1 comment
Closed

Extraneous parameters reported in v2 #40

rfay opened this issue May 20, 2024 · 1 comment

Comments

@rfay
Copy link
Contributor

rfay commented May 20, 2024

Thanks for all your work maintaining this, and your extreme responsiveness!

I happen to note in https://github.com/rfay/ddev-drushonhost/actions/runs/9155843472/job/25169006543#step:2:326 that there seem to be some obsolete parameters mentioned:

    commit_message: Automated commit by Keepalive Workflow to keep the repository active
    committer_username: gkr-bot
    committer_email: gkr-bot@tuta.io
    auto_push: true

IMO it would be clearer what's going on if these were cleaned up?

image

Thanks as always. And that workflow is in fact still running...

@gautamkrishnar
Copy link
Owner

@rfay the workflow still supports commit-based keepalive of the repositories. It is not removed. These parameters are kept to support that workflow and it is intentional.
Commit-based workflow example: https://github.com/gautamkrishnar/keepalive-workflow?tab=readme-ov-file#dummy-commit-keepalive-workflow-for-github-actions-users

You can safely ignore those parameters since they are not required ones. These will come into effect only if you use use_api: false

Repository owner locked and limited conversation to collaborators May 21, 2024
@gautamkrishnar gautamkrishnar converted this issue into discussion #41 May 21, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants