Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice projet, documentation missing #2

Closed
Bidou44 opened this issue May 8, 2016 · 1 comment
Closed

Nice projet, documentation missing #2

Bidou44 opened this issue May 8, 2016 · 1 comment

Comments

@Bidou44
Copy link

Bidou44 commented May 8, 2016

Your project looks promising.
The main problem is that it's not documented at all...

It would be really good to have a small documentation that explains the core principle, with the event mechanisms for example... The example you did is really good, but it's not sufficient.

Also, you could explain what is the goal of the Session, how one could interchange Autofact with another DI Framework, how one could bind Entity Framework, if it is possible to use the Window Service Bus instead of the InProcessBus class (or any other similar library), what is the snapshot strategy, and probably a lot more.
And what is the exact difference with Greg Young's project?

Concerning the code, I didn't go into the details, but I saw 2-3 small things:

  • Use TimeSpan.FromXXX instead of new TimeSpan(x, x, x....)
  • In the LoadAggreate method of the Repository, you could create the Aggregate just before the LoadFromHistory method
  • The IEventHandler interface could be contravariant
@gautema
Copy link
Owner

gautema commented May 8, 2016

Hi.

I haven't really prioritised creating much documentation, but there is a good resource on how to use the framework here: http://www.codeproject.com/Articles/991648/CQRS-A-Cross-Examination-Of-How-It-Works

This should both explain CQRS and this framework. The differences to Gregs example are quite big. Thats more of a simple example, while this project has made a library out of the example.

As for the code changes you suggested, you are welcome to make a pull request.

gautema added a commit that referenced this issue May 27, 2016
Cosmetics and changes discussed in #2
@gautema gautema closed this as completed May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants