Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion of StreamId or AggregateId in Event #27

Closed
petersondrew opened this issue Jun 5, 2017 · 4 comments
Closed

Discussion of StreamId or AggregateId in Event #27

petersondrew opened this issue Jun 5, 2017 · 4 comments

Comments

@petersondrew
Copy link
Contributor

I'm looking into implementing an IEventStore for other event stores (such as Greg's EventStore, or StreamStone, et al), and one of the requirements for those storage backends is that the stream or aggregate id be used to persist the event.

Based on the current signature of IEvent, that is not possible. Would you be open to accepting a PR with AggregateId added to the IEvent signature? It may also be easy enough to just add the aggregate or stream id as an argument to the IEventStore Get/Save methods.

Any thoughts on this? Thanks!

@petersondrew
Copy link
Contributor Author

On close inspection, AggregateId is already an argument to IEventStore.Get, so perhaps adding it as an argument to Save is the path of least resistance here?

@gautema
Copy link
Owner

gautema commented Jun 6, 2017 via email

@petersondrew
Copy link
Contributor Author

Ah, for some reason I was thinking that that was the unique event id in that context. If that is already the aggregate id then I have everything I need already. Oops.

@andrewmurray
Copy link

@petersondrew I'm curious as to how you got on with you implementation of Event Store with CqrsLite. Don't suppose you've read my issue #34 ? Did you have any problems with aggregate version concurrency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants