-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion of StreamId or AggregateId in Event #27
Comments
On close inspection, |
AggregateId is already on IEvent. It's just called id. Do you need it as an argument to save as well?
… On 6 Jun 2017, at 00:36, Drew Peterson ***@***.***> wrote:
On close inspection, AggregateId is already an argument to IEventStore.Get, so perhaps adding it as an argument to Save is the path of least resistance here?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Ah, for some reason I was thinking that that was the unique event id in that context. If that is already the aggregate id then I have everything I need already. Oops. |
@petersondrew I'm curious as to how you got on with you implementation of Event Store with CqrsLite. Don't suppose you've read my issue #34 ? Did you have any problems with aggregate version concurrency? |
I'm looking into implementing an IEventStore for other event stores (such as Greg's EventStore, or StreamStone, et al), and one of the requirements for those storage backends is that the stream or aggregate id be used to persist the event.
Based on the current signature of
IEvent
, that is not possible. Would you be open to accepting a PR withAggregateId
added to theIEvent
signature? It may also be easy enough to just add the aggregate or stream id as an argument to theIEventStore
Get/Save methods.Any thoughts on this? Thanks!
The text was updated successfully, but these errors were encountered: