Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do I need customRules? #37

Closed
MyWay opened this issue Nov 30, 2012 · 1 comment
Closed

Why do I need customRules? #37

MyWay opened this issue Nov 30, 2012 · 1 comment

Comments

@MyWay
Copy link

MyWay commented Nov 30, 2012

I'm referring to:
// Rules to remove predefined jQuery and Bootstrap and MooTools More
GKParser::$customRules['/<script src="(.*?)media\/jui\/js\/jquery.min.js" type="text\/javascript"></script>/mi'] = '';
GKParser::$customRules['/<script src="(.*?)media\/jui\/js\/jquery-noconflict.js" type="text\/javascript"></script>/mi'] = '';
GKParser::$customRules['/<script src="(.*?)media\/jui\/js\/bootstrap.min.js" type="text\/javascript"></script>/mi'] = '';
GKParser::$customRules['/<script src="(.*?)media\/system\/js\/mootools-more.js" type="text\/javascript"></script>/mi'] = '';

I'd like to remove these lines, because my modules need it, but I don't know if there is a specic reason of these. Thank you and sorry if an Issue is a wrong way to ask it to you.

@dziudek
Copy link
Contributor

dziudek commented Nov 30, 2012

Hi,

In general these scripts was removed due minifying the page size, so you can remove these rules if you need ;)

@dziudek dziudek closed this as completed Nov 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants