Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freecam movement speed #53

Closed
raydeejay opened this issue Mar 18, 2023 · 8 comments
Closed

Freecam movement speed #53

raydeejay opened this issue Mar 18, 2023 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@raydeejay
Copy link

raydeejay commented Mar 18, 2023

Describe the bug
Freecam moves too slowly in the horizontal plane, and maybe too fast in the vertical axis.

To Reproduce
Enable freecam.

Expected behavior
Horizontal movement faster or the same speed as vertical movement.

Version Info (please complete the following information):
1.4.1

@raydeejay raydeejay added the bug Something isn't working label Mar 18, 2023
@GT3CH1
Copy link
Member

GT3CH1 commented Mar 18, 2023

Thanks. I will look into this.

@GT3CH1
Copy link
Member

GT3CH1 commented Mar 18, 2023

What would you suggest be a comfortable speed for this? or would a user-controllable speed be something that would be nice to have?

@raydeejay
Copy link
Author

I suppose this is a rather subjective thing, if I had to choose one option I'd say variable speed in the way spectator mode works, but then I'm not the one implementing it 😁

At the very least it should be equivalent to walking speed. The upper limit doesn't have to be very high because the world around the player is presumably only a few chunks in each direction.

@GT3CH1
Copy link
Member

GT3CH1 commented Mar 18, 2023

No worries! I will take a look at it when I get some time.

@raydeejay
Copy link
Author

Since you're going to go over this anyway... two more things!

1/ shouldn't the player be able to phase into solid blocks when in freecam? (it is possible if NoClip is enabled)
2/ disabling freecam (even without activating Fly) leaves the player in flying state

@GT3CH1
Copy link
Member

GT3CH1 commented Mar 19, 2023

Thank you for your comment. Here are my thoughts on your questions.

  1. I've thought about this - I'm mixed between allowing the player to no-clip when free-cam is enabled, or have it toggleable through the no-clip feature itself. Other clients have it enabled automatically. It's trivial to have it be enabled when FreeCam is enabled/disabled, but then again I'm conflicted whether to allow this, as I prefer the features to be enabled/disable explicitly by the player rather than have some turn on automatically.

  2. I have addressed this issue. Thanks for informing me about it.

As for the FreeCam speed, I have implemented a setting to allow the user to change the scaling on it. There is one issue with it at the present moment - but it is a very minor one at best which may/may not get patched.

@raydeejay
Copy link
Author

If your intention is for the player to combine NoClip and FreeCam when they want, then I'd say leave it at that, it's definitely not a deal breaker!

There may be more reports as I keep trying things... 😁

@GT3CH1
Copy link
Member

GT3CH1 commented Mar 19, 2023

No worries! Bring them on! I'm just thrilled that someone out there is using my mod. There are a few housekeeping items I need to take care of before I release a version with the fix for this particular issue (ie, updating the readme with build instructions and such). So if you run into any more weird or strange things, please open another issue. In the mean time, I will be closing this one as the primary problem has been fixed and the fix exists in the 1.19.4-dev branch. Thanks!

@GT3CH1 GT3CH1 closed this as completed Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants