Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to waypoints #55

Closed
raydeejay opened this issue Mar 19, 2023 · 2 comments · Fixed by #56
Closed

Improvements to waypoints #55

raydeejay opened this issue Mar 19, 2023 · 2 comments · Fixed by #56
Assignees
Labels
enhancement New feature or request fixed fixed issues question Further information is requested v-1.19.4

Comments

@raydeejay
Copy link

Is your feature request related to a problem? Please describe.
Waypoints are managed through the settings menu. Additionally, they show in every dimension.

Describe the solution you'd like
I think waypoint management would make more sense in the main menu, since it's likely to be done often, while the rest of the settings seem more the kind of thing that's configured once and left alone for long.

As for showing in every dimension, asking for the dimension and then checking it before drawing the tracer/ESP should do the trick.

@raydeejay raydeejay added enhancement New feature or request question Further information is requested labels Mar 19, 2023
@GT3CH1
Copy link
Member

GT3CH1 commented Mar 20, 2023

I've implemented per-dimension checking for waypoints (something that should've been done long ago).
As for showing the management/settings menu, I don't think adding it to the main menu makes a lot of sense, as that menu is used for toggling the mods and not managing them. However, I have pulled the waypoints into their own settings category, so that it is not nested under "render" in the settings menu. The toggle for the mod is still under the "Render" group.

@raydeejay
Copy link
Author

Makes sense when put that way

@GT3CH1 GT3CH1 mentioned this issue Mar 20, 2023
2 tasks
@GT3CH1 GT3CH1 linked a pull request Mar 20, 2023 that will close this issue
2 tasks
@GT3CH1 GT3CH1 added v-1.19.4 fixed fixed issues labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed fixed issues question Further information is requested v-1.19.4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants