Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DefaultFormatter.EnableRequests and EnableResponses #159

Closed
gavv opened this issue Nov 23, 2022 · 6 comments · Fixed by #337
Closed

Add DefaultFormatter.EnableRequests and EnableResponses #159

gavv opened this issue Nov 23, 2022 · 6 comments · Fixed by #337
Assignees
Labels
feature New feature or request help wanted Contributions are welcome important Important task
Milestone

Comments

@gavv
Copy link
Owner

gavv commented Nov 23, 2022

Add two flags EnableRequests and EnableResponses to DefaultFormatter, which enable printing http.Request and http.Response on failure. New flags should be disabled by default.

Request and response instances are already present in AssertionContext passed to formatter. Formatted request and response should be added to FormatData and used in failure template. Formatting can be done using httputil, like we do it in DebugPrinter.

Formatted response should include round trip time (again like in DebugPrinter).

Related discussion: #137

See also #160.

@gavv gavv added feature New feature or request help wanted Contributions are welcome labels Nov 23, 2022
@gavv gavv added the important Important task label Dec 2, 2022
@gdguesser
Copy link
Contributor

Hello @gavv,

Could you please assign this one to me?

Thanks ;)

@gavv
Copy link
Owner Author

gavv commented Jan 23, 2023

Sure, thanks!

@gavv
Copy link
Owner Author

gavv commented Feb 18, 2023

@gdguesser hi, do you still plan to work on this?

@gdguesser
Copy link
Contributor

gdguesser commented Feb 18, 2023

Hey @gavv,

Thank you for checking in on the task. My apologies for not responding sooner, but I had to move to a new apartment. I am still fully committed to completing the task, but if you find that someone else is interested in it, I'm more than happy to let them take over. I appreciate your understanding, and I look forward to contributing to the project 🙂.

@gavv
Copy link
Owner Author

gavv commented Feb 18, 2023

No worries, take your time. People often abandon tasks, so I usually ping after a month or so. Good luck with the new apartment :)

@gavv
Copy link
Owner Author

gavv commented Mar 22, 2023

Created follow-up issue: #343

@gavv gavv added this to the v2 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Contributions are welcome important Important task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants