New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and improve TestRequest_URLInterpolate #326

Closed

gavv opened this issue Mar 3, 2023 · 1 comment

Labels

help wanted refactoring tests

Milestone

Owner

gavv commented Mar 3, 2023 •

edited

Loading

TestRequest_URLInterpolate covers usage of WithPath and WithPathObject.

Two changes are needed:

Split test into subtests, so that each request variable will be isolated and tested in its own subtest.
Add subtests to cover the following cases (coveralls reports that they are uncovered):
- WithPath: invalid interpol string (e.g. unmatched brace)
- WithPath: key not found
- WithPath: value is nil
- WithPathObject: invalid interpol string
- WithPathObject: key not found
- WithPathObject: value is nil

Related: #328, #283

gavv added tests help wanted refactoring labels

gavv mentioned this issue

Add more tests for Request #200

Closed

diPhantxm mentioned this issue

refactor request url interpolate tests #367

Merged

Owner Author

gavv commented Apr 3, 2023

Landed!

gavv closed this as completed

gavv added this to the v2 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment